This repository has been archived by the owner on Feb 17, 2021. It is now read-only.
[GH-175] totalSteps should be i18n-ified #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kate2753
commented
Jun 9, 2015
kate2753
commented
- Pass in i18n text for total tour step count into custom render function.
- Updated isLast flag to account for skipped steps
- Additional unit tests to cover mentioned changes
|
Cool, looks good to me! I'll pull this in tomorrow afternoon if there are no objections. |
timlindvall
added a commit
that referenced
this pull request
Jun 12, 2015
[GH-175] totalSteps should be i18n-ified
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.