Skip to content
This repository has been archived by the owner on Feb 17, 2021. It is now read-only.

Improve documentation of the target attribute of step elements. #253

Merged
merged 1 commit into from
Jun 24, 2016

Conversation

kemaldaggen
Copy link
Contributor

As discussed #105, current documentation makes people think that target parameter only accepts id of element or DOM element itself. In fact this is not true. This pull request contains extended documentation of behavior of target parameter.

@kevzettler
Copy link

lgtm

@timlindvall timlindvall added this to the 0.2.6 Maintenance Release milestone Jun 22, 2016
@timlindvall
Copy link
Contributor

Let's merge this in for sake of maintenance, though we probably should just remove this folder and use GH Pages as the source of truth moving forward. (I'll open a separate issue for this.)

@timlindvall timlindvall merged commit ff4b76f into LinkedInAttic:master Jun 24, 2016
@brondsem
Copy link

brondsem commented Jul 7, 2016

It would be nice if this could be published to http://linkedin.github.io/hopscotch/ I was about to make a similar pull request to update the target docs, but then noticed this was done already, just not published.

@timlindvall
Copy link
Contributor

Good call. Per #288, I'd like to kill off the /demo folder in master, so we have one source of truth for documentation. Part of that process should be making sure the content between the two sources agree with each other.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants