This repository has been archived by the owner on Feb 17, 2021. It is now read-only.
Refactor build to generate UMD and AMD artifacts #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timlindvall
suggested changes
May 30, 2017
timlindvall
approved these changes
May 31, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primary goal of this PR is to move away from src files containing UMD (or AMD) wrappers to instead allow for src files to be written as ES6 modules, and rely on the build to generate UMD/AMD artifacts. rollup (via grunt-rollup) is used along with babel (rollup-plugin-babel) are used to generate UMD and AMD artifacts, and to transpile ES6. In the dist/ directory, we output hopscotch_amd.js and hopscotch_amd.min.js, which are AMD artifacts. I also updated the Travis CI file, by updating the versions of Node used. All existing grunt tasks maintain functionality, and all existing artifacts remain. Only the AMD artifacts were added.
Testing done includes running all tasks, and running the Jasmine tests