This repository has been archived by the owner on Feb 17, 2021. It is now read-only.
Add changelog #64
Merged
Add changelog #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me. Having the proper tags is the big win, and we can figure out how we want to handle the changelog going forward. e.g. we can explore integrating it directly into the grunt release/tag task so it's always accurate. |
|
Agree with @eoneill, and the changes look good to me as well. |
…ra line between versions to see if that fixes it
…ra line between versions to see if that fixes it
|
Looks good to me... merging in to master. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per conversation in #60 used https://github.com/lalitkapoor/github-changes to generate CHANGELOG.md. This tool looks at tags, commits and pull requests to generate changelog. So I went through history of commits and tagged releases where version bump happened.
Take a look at tagged versions on my fork of the repo https://github.com/kate2753/hopscotch/releases. If they look good I will push those tags upstream as well.