This repository has been archived by the owner on Feb 17, 2021. It is now read-only.
IE8 Button Bindings Fix and Updated README with refreshBubblePosition #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hopscotch doesn't work in IE8. Hopscotch 0.2.0 broke it as in `_handleBubbleClick` `evt` argument will be undefined as it's not passed by IE8. Instead you have to grab the event from `window.event` object and find `currentTarget` as `evt.srcElement`. It probably requires some testing but seems to work for me.
ykka
changed the title
|
+1 to this pull request, things seem to be working in IE8 for me. |
|
Thanks! This change looks good to me. Edit: Never mind... diff looks ok on second pass. |
|
Awesome, thanks :) On 6 May 2014, at 03:20, zimmi88 notifications@github.com wrote: Thanks! This change looks good to me. Adding one nitpick to the diff, but — |
timlindvall
added a commit
that referenced
this pull request
May 7, 2014
IE8 Button Bindings Fix and Updated README with refreshBubblePosition
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--- 1 ---
Hopscotch doesn't work in IE8. Hopscotch 0.2.0 broke it as in
_handleBubbleClickevtargument will be undefined as it's not passed by IE8. Instead you have to grab the event fromwindow.eventobject and findcurrentTargetasevt.srcElement.It probably requires some testing but seems to work for me.
--- 2 ---
Updated README.md with Hopscotch's
refreshBubblePositionAPI method in 0.2.0