Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kubectl get-style resource parsing to conduit stat CLI command #683

Closed
rmars opened this issue Apr 5, 2018 · 3 comments
Closed

Add kubectl get-style resource parsing to conduit stat CLI command #683

rmars opened this issue Apr 5, 2018 · 3 comments

Comments

@rmars
Copy link

rmars commented Apr 5, 2018

The queries proposed in #627 require more sophisticated parsing than the stat summary endpoints currently do. (Current implementation in #671 just takes a singular resource and name).

Add parsing to the CLI to take queries such as the following and generate a series of StatSummaryRequests.

  # Stat all replication controllers and services together.
  conduit stat rc,services

  # Stat one or more resources by their type and names.
  conduit stat rc/web service/frontend pods/web-pod-13je7
@rmars rmars added this to the 0.4.0 milestone Apr 5, 2018
@siggy siggy modified the milestones: 0.4.0, 0.5.0 Apr 10, 2018
@klingerf klingerf modified the milestones: 0.5.0, 0.4.1 Apr 16, 2018
@klingerf klingerf changed the title Add kubectl get-style resource parsing to conduit statsummary CLI command Add kubectl get-style resource parsing to conduit stat CLI command Apr 16, 2018
@klingerf
Copy link
Contributor

klingerf commented Apr 16, 2018

As part of this change, we should also enable kubectl-style resource parsing for the --to* and --from* flags.

For example, as it's currently implemented, if you wanted to query all of the namespaces that send traffic to the "foo" deployment in the default namespace, you'd use:

conduit stat ns --to foo --to-resource deployment --to-namespace default

But we should make the --to flag resource-aware, such that you can instead run:

conduit stat ns --to deploy/foo --to-namespace default

And we should remove the --to-resource and --from-resource flags altogether.

@siggy
Copy link
Member

siggy commented Apr 25, 2018

Moving this into 0.5.0 milestone. This task is mostly complete. What remains is handling comma-separated lists of resource strings.

@siggy siggy modified the milestones: 0.4.1, 0.5.0 Apr 25, 2018
@klingerf klingerf removed this from the 0.5.0 milestone May 29, 2018
@stale
Copy link

stale bot commented Oct 7, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 7, 2018
@stale stale bot closed this as completed Oct 23, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants