Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service support in tap command #806

Closed
siggy opened this issue Apr 19, 2018 · 1 comment
Closed

service support in tap command #806

siggy opened this issue Apr 19, 2018 · 1 comment

Comments

@siggy
Copy link
Member

siggy commented Apr 19, 2018

Once #802 and #803 are implemented, the tap command will support the following for target and match ResourceSelection's:
https://github.com/runconduit/conduit/blob/653dc6bfaac3f5d0feafe1dc214f28f8bc89a3fb/controller/api/public/stat_summary.go#L49-L54

Modify this to support service objects on the match ResourceSelection.

Depends on #802 and #803.

Part of #778.

@siggy siggy added this to the 0.4.1 milestone Apr 19, 2018
@siggy
Copy link
Member Author

siggy commented Apr 23, 2018

Resolved in #827.

$ bin/conduit tapByResource -n emojivoto deploy/web --to svc/voting-svc
req id=0:2349 src=10.1.7.197:56018 dst=10.1.7.196:8080 :method=POST :authority=voting-svc.emojivoto:8080 :path=/emojivoto.v1.VotingService/VotePoop
rsp id=0:2349 src=10.1.7.197:56018 dst=10.1.7.196:8080 :status=200 latency=2903µs
end id=0:2349 src=10.1.7.197:56018 dst=10.1.7.196:8080 grpc-status=Unknown duration=0µs response-length=0B

@siggy siggy closed this as completed Apr 23, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant