-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug or feature?] pod being killed continuously #588
Comments
If you think this is a bug or feature, please assign it to me |
The killed Pod's name is different, so from the perspective of The second Pod shouldn't be killed before it's in the If your "test" application consists of a single Pod, then the |
--minimum-age , it's use pod.ObjectMeta.CreationTimestamp check it. so, pods that have been created but are still being started may still be killed. I don't think killing the starting pod is the desired result. I think it is reasonable to use such an implementation, or add a user-oriented parameter to determine whether to kill the starting pod.
|
Looking at the code Pods that are not in What can happen is that if you set minimum age to 5 minutes and the Pod itself stays 5 minutes in "Pending" or "Initializing" state, it can get killed right after it switches to "Running". (Because CreationTimestamp is the time the Pod object was created initially.) |
I believe we understand each other. It was my negligence that I didn't notice the "running" status judgment. |
We should think about it. If a Pod only gets into the But it might be difficult to implement. Looking at the However, the current implementation works for most of the cases in real-world clusters that run many Pods. We don't do it currently, but termination during the initialization phase can also be preferable for some users to uncover additional edge cases. |
the default namespace has two pods, run
go run main.go --interval 10s --namespaces 'default' --no-dry-run
the test pod was killed repeatedly, I think this is unfriendly in some scenarios. Is this expected behavior?
questions:
--minimum-age
, it's usepod.ObjectMeta.CreationTimestamp
check it, but it is possible that the pod will be killed again while it is still starting.--minimum-age
cannot solve the problem of the same pod being killed continuously.The text was updated successfully, but these errors were encountered: