Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inline aggregate assets doesn't work as intended #63

Open
jwebbdev opened this issue Jul 29, 2015 · 0 comments
Open

inline aggregate assets doesn't work as intended #63

jwebbdev opened this issue Jul 29, 2015 · 0 comments

Comments

@jwebbdev
Copy link
Member

/pull/62 fixes a crash caused when trying to aggregateAssets but there is no way, beyond parsing the results of res.locals.aggregatedassets for strings starting with <script> and <style> to know whether an asset is inline.

In the current mean.io implementation all strings are wrapped in the header/footer with link and script tags, which fails to handle inline assets.

A more elegant solution than adding a lot of string parsing to the core/system/server/controllers/index.js in mean, may be to create a res.locals.aggregatedassets.header.inline, and footer.inline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant