Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AggregateAssets weights should probably be affected by dependency #65

Open
jwebbdev opened this issue Aug 3, 2015 · 2 comments
Open

Comments

@jwebbdev
Copy link
Member

jwebbdev commented Aug 3, 2015

The order of dependencies doesn't affect the files in aggregate assets. The issue this presents is with css. If I have a package dependent on my theme package, and I attempt to use a font that my theme has included the only way to ensure it is loaded is to set weights across packages, which seems like a bad way to handle it since a package you depend on may not have weights set already.

@BrockMcKean
Copy link

So, this is a huge problem that needs to be resolved through mean.json. If mean.json could provide a dependency tree configuration of mean packages that described the application (root of the dependency tree) and all of its dependent components (all other packages that it depends on), aggregation could be done in this order and be expected to work properly. Obviously, this would lead to specific patterns being chosen to do certain things and in some ways limit the freedom developers would have, but also would solve problems like these very easily in one swoop.

@timelf123
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants