Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

having a substring "model" somewhere in the path causes app to crash #94

Open
sometea opened this issue Feb 2, 2016 · 2 comments
Open

Comments

@sometea
Copy link

sometea commented Feb 2, 2016

As described in linnovate/mean#1283

If the mean app has a name that contains a substring "model", then the app crashes while injecting the "circle" or "user" modules. This happens if the path of the app contains the substring "model". Out of curiosity, I had a look into this bug. It occurs due to the way the "type" of a path is checked in the walk function in util.js. I think I could fix this, will try to submit a PR later.

@ADSKLowenthal
Copy link
Contributor

@sometea Did you have a chance to issue a PR? Is this still an issue?

@sometea
Copy link
Author

sometea commented Sep 21, 2016

I did, see #95
You seemed to have had some doubts with the solution though which I didn't fully comprehend, I can check again. I can also check if this is still an issue with current master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants