Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added policy setting to external-dns values #1793

Merged
merged 3 commits into from
Nov 6, 2024
Merged

feat: added policy setting to external-dns values #1793

merged 3 commits into from
Nov 6, 2024

Conversation

merll
Copy link
Contributor

@merll merll commented Nov 4, 2024

This PR adds the policy setting supported by external-dns to the APL values schema. This does not change the default behavior. For now this is not yet added to API / console.

Checklist

  • Architecture Design Records have been added as adr/*.md and appended to list in adr/_index.md, if applicable.
  • The values-schema.yaml file and test/** fixtures have been updated to reflect code changes, if applicable.
  • The OpenApi Schema from redkubes/otomi-api project is compatible with definitions from values-schema.yaml file, if applicable.
  • Helm releases are meeting otomi's baseline security policies, if applicable.
  • Helm chart and helmfile changes are tested against upgrade scenario, if applicable.

@merll merll changed the title APL-300: added policy setting to external-dns values feat: added policy setting to external-dns values Nov 4, 2024
@Ani1357 Ani1357 self-requested a review November 4, 2024 13:40
Ani1357
Ani1357 approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@Ani1357 Ani1357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CasLubbers
CasLubbers approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@CasLubbers CasLubbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small remark

values-schema.yaml Outdated Show resolved Hide resolved
@merll merll enabled auto-merge (squash) November 6, 2024 12:21
@merll merll disabled auto-merge November 6, 2024 12:21
@merll merll merged commit d6d9741 into main Nov 6, 2024
5 checks passed
@merll merll deleted the apl-300-external-dns-policy branch November 6, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ani1357 Ani1357 Ani1357 approved these changes

@CasLubbers CasLubbers CasLubbers approved these changes

@j-zimnowoda j-zimnowoda Awaiting requested review from j-zimnowoda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@merll @CasLubbers @Ani1357