Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some questions to this project #18

Open
ptr1337 opened this issue May 11, 2022 · 2 comments
Open

Some questions to this project #18

ptr1337 opened this issue May 11, 2022 · 2 comments

Comments

@ptr1337
Copy link

ptr1337 commented May 11, 2022

Hey,

first great idea this project, really looking forward.

The questions I got:

Actually every built binary need be built with --emit-relocs , so that bolt works.
So, the distribution should all compile the packages with that, or do you have another solution for that ?

Changing the language from russian to english so that every user understand it would be also nice.

How about cpu's which does not support perf record (eg amd ones)?
Do you plan to implement the feature -instrument and then bolt the binary after enough data is made ?

Regards.

@aaupov
Copy link
Contributor

aaupov commented May 11, 2022

Hi @ptr1337,

Thank you for your interest in this project and insightful straight to the point questions.

Please note that this is a high school project implemented by Maksim @M4RFF. It's not ready for general use yet, so think of it as a prototype.

Actually every built binary need be built with --emit-relocs , so that bolt works.
So, the distribution should all compile the packages with that, or do you have another solution for that ?

It's true that to get the most benefit, the object file would need to be linked with relocations. But 1) BOLT works in non-relocation mode as well, 2) perfd may detect a lack of relocs and either warn about it or deprioritize the application.

Changing the language from russian to english so that every user understand it would be also nice.

It would be addressed soon. I'll help Maksim with it but let him add documentation in Russian first.

How about cpu's which does not support perf record (eg amd ones)?
Do you plan to implement the feature -instrument and then bolt the binary after enough data is made ?

It's a valid concern. You're right, perfd would need to detect the presence of LBR and perhaps use non-LBR sampling otherwise (frame ptr stack unwinding, as DWARF is unlikely to be available either). The instrumentation mode might be added as an extension too.

@ptr1337
Copy link
Author

ptr1337 commented May 12, 2022

Hey,
thanks for your fast answer!

Yes, i already saw that it a school project, very cool :)

Actually im very interested into this project to include it as opt in into my optimized distribution as which I currently develop and work on.
I did already worked with bolt but never got on the idea with the systemd service, looking forward to contribute into this project as soon the the "base" is commited into the branch.

Looking forward into this!

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants