Skip to content

Commit 351461f

Browse files
committed
svcrdma: Don't leak send_ctxt on Send errors
Address a rare send_ctxt leak in the svc_rdma_sendto() error paths. Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
1 parent b73ac68 commit 351461f

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

net/sunrpc/xprtrdma/svc_rdma_sendto.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -936,7 +936,7 @@ int svc_rdma_sendto(struct svc_rqst *rqstp)
936936
p = xdr_reserve_space(&sctxt->sc_stream,
937937
rpcrdma_fixed_maxsz * sizeof(*p));
938938
if (!p)
939-
goto err0;
939+
goto err1;
940940

941941
ret = svc_rdma_send_reply_chunk(rdma, rctxt, &rqstp->rq_res);
942942
if (ret < 0)
@@ -948,11 +948,11 @@ int svc_rdma_sendto(struct svc_rqst *rqstp)
948948
*p = pcl_is_empty(&rctxt->rc_reply_pcl) ? rdma_msg : rdma_nomsg;
949949

950950
if (svc_rdma_encode_read_list(sctxt) < 0)
951-
goto err0;
951+
goto err1;
952952
if (svc_rdma_encode_write_list(rctxt, sctxt) < 0)
953-
goto err0;
953+
goto err1;
954954
if (svc_rdma_encode_reply_chunk(rctxt, sctxt, ret) < 0)
955-
goto err0;
955+
goto err1;
956956

957957
ret = svc_rdma_send_reply_msg(rdma, sctxt, rctxt, rqstp);
958958
if (ret < 0)

0 commit comments

Comments
 (0)