Skip to content

Commit 962cff4

Browse files
Navidemgregkh
authored andcommitted
RDMA/hfi1: Prevent memory leak in sdma_init
[ Upstream commit 34b3be1 ] In sdma_init if rhashtable_init fails the allocated memory for tmp_sdma_rht should be released. Fixes: 5a52a7a ("IB/hfi1: NULL pointer dereference when freeing rhashtable") Link: https://lore.kernel.org/r/20190925144543.10141-1-navid.emamdoost@gmail.com Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com> Acked-by: Dennis Dalessandro <dennis.dalessandro@intel.com> Signed-off-by: Jason Gunthorpe <jgg@mellanox.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent dfc1dab commit 962cff4

File tree

1 file changed

+4
-1
lines changed
  • drivers/infiniband/hw/hfi1

1 file changed

+4
-1
lines changed

drivers/infiniband/hw/hfi1/sdma.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1518,8 +1518,11 @@ int sdma_init(struct hfi1_devdata *dd, u8 port)
15181518
}
15191519

15201520
ret = rhashtable_init(tmp_sdma_rht, &sdma_rht_params);
1521-
if (ret < 0)
1521+
if (ret < 0) {
1522+
kfree(tmp_sdma_rht);
15221523
goto bail;
1524+
}
1525+
15231526
dd->sdma_rht = tmp_sdma_rht;
15241527

15251528
dd_dev_info(dd, "SDMA num_sdma: %u\n", dd->num_sdma);

0 commit comments

Comments
 (0)