Skip to content

Commit bb0abfa

Browse files
StollDqzed
authored andcommitted
ipts: Remove no_feedback quirk
Since the previous commit appears to fix the crashes on gen4 that required no_feedback, quirking these devices is not neccessary anymore. Signed-off-by: Dorian Stoll <dorian.stoll@tmsp.io>
1 parent 17e1296 commit bb0abfa

File tree

4 files changed

+2
-8
lines changed

4 files changed

+2
-8
lines changed

drivers/misc/ipts/companion/ipts-surface.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,13 +34,13 @@ struct ipts_surface_data {
3434
// Surface Book 1 / Surface Studio
3535
static const struct ipts_surface_data ipts_surface_mshw0076 = {
3636
.hid = "MSHW0076",
37-
.quirks = IPTS_QUIRK_NO_FEEDBACK,
37+
.quirks = IPTS_QUIRK_NONE,
3838
};
3939

4040
// Surface Pro 4
4141
static const struct ipts_surface_data ipts_surface_mshw0078 = {
4242
.hid = "MSHW0078",
43-
.quirks = IPTS_QUIRK_NO_FEEDBACK,
43+
.quirks = IPTS_QUIRK_NONE,
4444
};
4545

4646
// Surface Laptop 1 / 2

drivers/misc/ipts/params.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ struct ipts_params ipts_modparams = {
1818
.ignore_fw_fallback = false,
1919
.ignore_config_fallback = false,
2020
.ignore_companion = false,
21-
.no_feedback = -1,
2221

2322
.debug = false,
2423
.debug_thread = false,
@@ -33,9 +32,6 @@ IPTS_PARAM(ignore_config_fallback, bool, 0400,
3332
IPTS_PARAM(ignore_companion, bool, 0400,
3433
"Don't use a companion driver to load firmware. (default: false)"
3534
);
36-
IPTS_PARAM(no_feedback, int, 0644,
37-
"Disable sending feedback to ME (can prevent crashes on Skylake). (-1=auto [default], 0=false, 1=true)"
38-
);
3935

4036
IPTS_PARAM(debug, bool, 0400,
4137
"Enable IPTS debugging output. (default: false)"

drivers/misc/ipts/params.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ struct ipts_params {
1515
bool ignore_fw_fallback;
1616
bool ignore_config_fallback;
1717
bool ignore_companion;
18-
int no_feedback;
1918

2019
bool debug;
2120
bool debug_thread;

include/linux/ipts.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,5 @@
1515
#define MAX_IOCL_FILE_PATH_LEN 256
1616

1717
#define IPTS_QUIRK_NONE 0
18-
#define IPTS_QUIRK_NO_FEEDBACK BIT(0)
1918

2019
#endif // IPTS_H

0 commit comments

Comments
 (0)