Skip to content

Commit e6f4f34

Browse files
chao-pbonzini
authored andcommitted
KVM: selftests: Add KVM_SET_USER_MEMORY_REGION2 helper
Add helpers to invoke KVM_SET_USER_MEMORY_REGION2 directly so that tests can validate of features that are unique to "version 2" of "set user memory region", e.g. do negative testing on gmem_fd and gmem_offset. Provide a raw version as well as an assert-success version to reduce the amount of boilerplate code need for basic usage. Signed-off-by: Chao Peng <chao.p.peng@linux.intel.com> Signed-off-by: Ackerley Tng <ackerleytng@google.com> Signed-off-by: Sean Christopherson <seanjc@google.com> Message-Id: <20231027182217.3615211-33-seanjc@google.com> Reviewed-by: Fuad Tabba <tabba@google.com> Tested-by: Fuad Tabba <tabba@google.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
1 parent 43f623f commit e6f4f34

File tree

2 files changed

+36
-0
lines changed

2 files changed

+36
-0
lines changed

tools/testing/selftests/kvm/include/kvm_util_base.h

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -522,6 +522,13 @@ void vm_set_user_memory_region(struct kvm_vm *vm, uint32_t slot, uint32_t flags,
522522
uint64_t gpa, uint64_t size, void *hva);
523523
int __vm_set_user_memory_region(struct kvm_vm *vm, uint32_t slot, uint32_t flags,
524524
uint64_t gpa, uint64_t size, void *hva);
525+
void vm_set_user_memory_region2(struct kvm_vm *vm, uint32_t slot, uint32_t flags,
526+
uint64_t gpa, uint64_t size, void *hva,
527+
uint32_t guest_memfd, uint64_t guest_memfd_offset);
528+
int __vm_set_user_memory_region2(struct kvm_vm *vm, uint32_t slot, uint32_t flags,
529+
uint64_t gpa, uint64_t size, void *hva,
530+
uint32_t guest_memfd, uint64_t guest_memfd_offset);
531+
525532
void vm_userspace_mem_region_add(struct kvm_vm *vm,
526533
enum vm_mem_backing_src_type src_type,
527534
uint64_t guest_paddr, uint32_t slot, uint64_t npages,

tools/testing/selftests/kvm/lib/kvm_util.c

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -873,6 +873,35 @@ void vm_set_user_memory_region(struct kvm_vm *vm, uint32_t slot, uint32_t flags,
873873
errno, strerror(errno));
874874
}
875875

876+
int __vm_set_user_memory_region2(struct kvm_vm *vm, uint32_t slot, uint32_t flags,
877+
uint64_t gpa, uint64_t size, void *hva,
878+
uint32_t guest_memfd, uint64_t guest_memfd_offset)
879+
{
880+
struct kvm_userspace_memory_region2 region = {
881+
.slot = slot,
882+
.flags = flags,
883+
.guest_phys_addr = gpa,
884+
.memory_size = size,
885+
.userspace_addr = (uintptr_t)hva,
886+
.guest_memfd = guest_memfd,
887+
.guest_memfd_offset = guest_memfd_offset,
888+
};
889+
890+
return ioctl(vm->fd, KVM_SET_USER_MEMORY_REGION2, &region);
891+
}
892+
893+
void vm_set_user_memory_region2(struct kvm_vm *vm, uint32_t slot, uint32_t flags,
894+
uint64_t gpa, uint64_t size, void *hva,
895+
uint32_t guest_memfd, uint64_t guest_memfd_offset)
896+
{
897+
int ret = __vm_set_user_memory_region2(vm, slot, flags, gpa, size, hva,
898+
guest_memfd, guest_memfd_offset);
899+
900+
TEST_ASSERT(!ret, "KVM_SET_USER_MEMORY_REGION2 failed, errno = %d (%s)",
901+
errno, strerror(errno));
902+
}
903+
904+
876905
/* FIXME: This thing needs to be ripped apart and rewritten. */
877906
void vm_mem_add(struct kvm_vm *vm, enum vm_mem_backing_src_type src_type,
878907
uint64_t guest_paddr, uint32_t slot, uint64_t npages,

0 commit comments

Comments
 (0)