Skip to content

Commit f999e23

Browse files
mrhpearsonjwrdegoede
authored andcommitted
platform/x86: thinkpad_acpi: Fix lkp-tests warnings for platform profiles
Fix issues identified in dytc_profile_refresh identified by lkp-tests. drivers/platform/x86/thinkpad_acpi.c:10538 dytc_profile_refresh() error: uninitialized symbol 'funcmode'. drivers/platform/x86/thinkpad_acpi.c:10531 dytc_profile_refresh() error: uninitialized symbol 'output'. drivers/platform/x86/thinkpad_acpi.c:10537 dytc_profile_refresh() error: uninitialized symbol 'output'. These issues should not lead to real problems in the field as the refresh function should only be called if MMC or PSC mode enabled. But good to fix. Thanks to Dan Carpenter and the lkp-tests project for flagging these. Reported-by: kernel test robot <lkp@intel.com> Reported-by: Dan Carpenter <error27@gmail.com> Closes: https://lore.kernel.org/r/202306011202.1hbgLRD4-lkp@intel.com/ Fixes: 1bc5d81 ("platform/x86: thinkpad_acpi: Fix profile modes on Intel platforms") Signed-off-by: Mark Pearson <mpearson-lenovo@squebb.ca> Link: https://lore.kernel.org/r/20230606151804.8819-1-mpearson-lenovo@squebb.ca Reviewed-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
1 parent 2515e54 commit f999e23

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

drivers/platform/x86/thinkpad_acpi.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10524,8 +10524,8 @@ static int dytc_profile_set(struct platform_profile_handler *pprof,
1052410524
static void dytc_profile_refresh(void)
1052510525
{
1052610526
enum platform_profile_option profile;
10527-
int output, err = 0;
10528-
int perfmode, funcmode;
10527+
int output = 0, err = 0;
10528+
int perfmode, funcmode = 0;
1052910529

1053010530
mutex_lock(&dytc_mutex);
1053110531
if (dytc_capabilities & BIT(DYTC_FC_MMC)) {
@@ -10538,6 +10538,8 @@ static void dytc_profile_refresh(void)
1053810538
err = dytc_command(DYTC_CMD_GET, &output);
1053910539
/* Check if we are PSC mode, or have AMT enabled */
1054010540
funcmode = (output >> DYTC_GET_FUNCTION_BIT) & 0xF;
10541+
} else { /* Unknown profile mode */
10542+
err = -ENODEV;
1054110543
}
1054210544
mutex_unlock(&dytc_mutex);
1054310545
if (err)

0 commit comments

Comments
 (0)