Remove some magic numbers.

archseer · archseer · commit 2b3ebcb511cb · 2019-11-07T21:47:43.000+09:00
diff --git a/module/surface_sam_vhf.c b/module/surface_sam_vhf.c
@@ -663,7 +663,7 @@ static int vhf_hid_raw_request(struct hid_device *hid, unsigned char reportnum,
 	}
 
 	struct surface_sam_ssh_rqst rqst = {
-		.tc  = 0x15,
+		.tc  = SAM_EVENT_VHF_TC,
 		.pri = SURFACE_SAM_PRIORITY_HIGH,
 		.iid = iid,
 		.cid = cid,
@@ -730,7 +730,7 @@ static int vhf_event_handler(struct surface_sam_ssh_event *event, void *data)
 {
 	struct vhf_evtctx *ctx = (struct vhf_evtctx *)data;
 
-	if (event->tc == 0x15 && (event->cid == 0x00 || event->cid == 0x03 || event->cid == 0x04)) {
+	if (event->tc == SAM_EVENT_VHF_TC && (event->cid == 0x00 || event->cid == 0x03 || event->cid == 0x04)) {
 		return hid_input_report(ctx->hid, HID_INPUT_REPORT, event->pld, event->len, 1);
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -663,7 +663,7 @@ static int vhf_hid_raw_request(struct hid_device *hid, unsigned char reportnum,`
`663`	`663`	`}`
`664`	`664`
`665`	`665`	`struct surface_sam_ssh_rqst rqst = {`
`666`		`- .tc = 0x15,`
	`666`	`+ .tc = SAM_EVENT_VHF_TC,`
`667`	`667`	`.pri = SURFACE_SAM_PRIORITY_HIGH,`
`668`	`668`	`.iid = iid,`
`669`	`669`	`.cid = cid,`
`@@ -730,7 +730,7 @@ static int vhf_event_handler(struct surface_sam_ssh_event event, void data)`
`730`	`730`	`{`
`731`	`731`	`struct vhf_evtctx ctx = (struct vhf_evtctx )data;`
`732`	`732`
`733`		`- if (event->tc == 0x15 && (event->cid == 0x00 \|\| event->cid == 0x03 \|\| event->cid == 0x04)) {`
	`733`	`+ if (event->tc == SAM_EVENT_VHF_TC && (event->cid == 0x00 \|\| event->cid == 0x03 \|\| event->cid == 0x04)) {`
`734`	`734`	`return hid_input_report(ctx->hid, HID_INPUT_REPORT, event->pld, event->len, 1);`
`735`	`735`	`}`
`736`	`736`