Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCIe/NVME may not be described correctly #26

Open
qzed opened this issue Jun 12, 2022 · 1 comment
Open

PCIe/NVME may not be described correctly #26

qzed opened this issue Jun 12, 2022 · 1 comment
Labels
A: SoC Area: Qualcomm SoC drivers

Comments

@qzed
Copy link
Member

qzed commented Jun 12, 2022

While the PCIe NVME drive seems to work well, it may not be described correctly. According to spec, it uses four PCIe lanes, stemming from controllers 1 and 2, each providing two lanes. This bonding together of controllers/lanes doesn't seem to be described properly in the DT yet. It apparently also requires some more driver work to do so.

At the moment, we may rely on UEFI configuring everything for us. This could lead to problems when suspending, where that config may be lost.

@qzed qzed added the A: SoC Area: Qualcomm SoC drivers label Jun 12, 2022
This was referenced Jun 12, 2022
@qzed
Copy link
Member Author

qzed commented Jun 25, 2022

Quoting @andersson form aarch64-laptops IRC:

there's a register which defines if the phys work separately or in tandem...in tandem the initialization sequence needs to initialize both phys, in a slightly different way from when they are separate

I've decided to set num-lanes = <2> for now, which hopefully lets us avoid the second (unconfigured) phy. That way we can hopefully get a stable configuration for experimenting with suspend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: SoC Area: Qualcomm SoC drivers
Projects
Status: Todo
Development

No branches or pull requests

1 participant