Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(CI): add debian check workflow #348

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

kuchune
Copy link
Contributor

@kuchune kuchune commented Jul 11, 2024

add debian check workflow

log: 增加debian检查工作流

  add debian check workflow

log: 增加debian检查工作流
@deepin-ci-robot
Copy link

Hi @kuchune. Thanks for your PR. 😃

@deepin-ci-robot
Copy link

Hi @kuchune. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Aug 5, 2024

TAG Bot

New tag: 6.0.14
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #349

@hudeng-go
Copy link
Contributor

/ok-to-test

@hudeng-go
Copy link
Contributor

/approve

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 工作流名称使用了小写字母,建议使用大写字母以符合GitHub的命名规范。
  • 工作流中使用了inherit来继承secrets,但未提供上下文说明为何需要这样做。
  • 工作流中未定义任何envsecrets,这可能不是预期的行为,应该确认是否需要这些配置。

是否建议立即修改:

  • 是,建议立即修改工作流名称,使用大写字母以符合GitHub的命名规范。
  • 是,如果inherit的使用没有明确的理由,应该提供更多的上下文或文档说明。
  • 是,如果工作流需要环境变量或密钥,应该定义这些环境变量或使用secrets。

Copy link
Contributor

@ArchieMeng ArchieMeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ArchieMeng, hudeng-go, kuchune

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ArchieMeng ArchieMeng merged commit 3e1cbfe into linuxdeepin:master Aug 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants