Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect icons for Deepin after change to another icon theme under archlinux #28

Closed
oberon-manjaro opened this issue Jan 30, 2016 · 9 comments

Comments

@oberon-manjaro
Copy link

Hello everyone! :)
Thank you all for you great work on developing Deepin. You are all awesome! 😆
I would like to draw your attention to a little issue with the launcher icon: As soon as you are using a different icontheme this icon in the dock is lost because it seems to only exist in deepin-icon theme and none of the usual themes falls back to deepin-theme of course.
Would it maybe be an option to install the launcher icon to the hicolor directory?

@oberon-manjaro
Copy link
Author

In the case of the deepin-multitasking-view icon it works perfectly no matter which icontheme I use. So this could serve as a model for a good solution probably :)

@fasheng
Copy link
Contributor

fasheng commented Jan 30, 2016

Yes, there are hicolor links in deepin-icon-theme under Deepin, but only implemented through the Debian package methods. Anyway, it's not a good style...

@oberon-manjaro
Copy link
Author

Ah, maybe then it has to be solved in the dock itself? How are the other entries dealing with that? multitasking-view and all the icons in the notification area are always displayed fine. Just the launcher icon has that problem...

@oberon-manjaro
Copy link
Author

also deepin-music and deepin-movie always use the deepin-icons in another theme.

@fasheng fasheng changed the title launcher icon Incorrect icons for Deepin after change to another icon theme under archlinux Feb 1, 2016
@fasheng
Copy link
Contributor

fasheng commented Feb 1, 2016

@Oberon2007 Because deepin-musci and deepin-movie put there icons to /usr/share/icons/hicolor/~

Why not we use Makefile instead of debian/links in deepin-icon-theme? :)
@leaeasy @gs342

@snyh
Copy link
Member

snyh commented Feb 1, 2016

@fasheng it seems avoid conflicting file with other packages

@oberon-manjaro
Copy link
Author

You could also have deepin-launcher install its own icon or a symlink to hicolor :)
I have worked around this for now by doing that with deepin-iconthemes-manjaro package. I would have to remove it from there in time in case you decide to add it to one of the deepin-packages ... ;)

@fasheng
Copy link
Contributor

fasheng commented Feb 1, 2016

I see, how about support it in Makefile firstly, and will be helpfull for other distros.
BTW: It's not urgency ;)

@hualet
Copy link
Contributor

hualet commented Jun 12, 2017

DDE specific icons are also linked to hicolor folders by deepin-icon-theme while deepin Apps specific icons are taken care of by Apps themselves, long over due issue solved :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants