Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: from linuxdeepin/dtkdeclarative #127

Closed
wants to merge 1 commit into from

Conversation

deepin-ci-robot
Copy link
Contributor

Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#361

@deepin-ci-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#361
@deepin-ci-robot
Copy link
Contributor Author

deepin pr auto review

关键摘要:

  • ArrowListView.qml中,highlight矩形组件的属性被重复定义,应该删除重复的anchors属性。
  • Menu.qml中,topPadding的值被硬编码为6,建议使用常量或从配置文件中读取。
  • MenuItem.qml中删除了Loader组件,这可能会影响布局和样式,需要确认这是否是预期的更改。

是否建议立即修改:

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Aug 21, 2024

TAG Bot

New tag: 6.0.19
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #148

@kegechen kegechen added the hold-on should not merge now label Sep 11, 2024
@kegechen
Copy link
Contributor

too many rebot prs

@kegechen kegechen closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold-on should not merge now
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants