Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Gutenberg blocks to replace Stackable and deprecate Stackable blocks #436

Closed
3 tasks
cjyabraham opened this issue Jan 23, 2020 · 3 comments
Closed
3 tasks
Assignees
Labels

Comments

@cjyabraham
Copy link
Collaborator

cjyabraham commented Jan 23, 2020

Now that Gutenberg blocks have matured, let's deprecate our use of Stackable and use Gutenberg blocks going forward. There are problems with keeping on the latest version of Stackable and the way it is being developed don't align with our needs. We'll need to keep Stackable around for Events that currently use it.

  • Update Gutenberg block styles to mimic what we are doing with Stackable blocks
  • Teach Megan how to use the Gutenberg blocks
  • Turn off all Stackable blocks from the block chooser that we have found a good replacement for so that they can no longer be used

Here's a quick summary of how Stackable blocks are currently used on the site:

  1. Hero Container block; easily replaced with a Group block.
  2. Section Header; can be replaced with a Group block.
  3. Schedule-at-a-glance Container block; can be replaced by Group.
  4. Feature grid on China site
  5. Image box on this page and here and here and here

We should replace the blocks we only have a few instances of (4 and 5 above) and then cut out only the css we need to render the blocks we keep (1, 2 and 3) and include it conditionally on only the pages that need them. Then we can uninstall the stackable plugin entirely.

Alternatively we could go through all old pages and replace all stackable blocks.

@cjyabraham
Copy link
Collaborator Author

We're going to hold off on this for now until Megan and her team have time to absorb a change like this and also until Gutenberg matures a bit more.

@cjyabraham
Copy link
Collaborator Author

Find my blocks could be useful to find where Stackable is being used.

@cjyabraham
Copy link
Collaborator Author

Closing in favor of #576

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

1 participant