Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The envelope clicks when stopping a voice to start a new one #14

Open
jpcima opened this issue Dec 24, 2019 · 2 comments
Open

The envelope clicks when stopping a voice to start a new one #14

jpcima opened this issue Dec 24, 2019 · 2 comments

Comments

@jpcima
Copy link
Member

jpcima commented Dec 24, 2019

Make it a clean transition.

@jpcima
Copy link
Member Author

jpcima commented Dec 24, 2019

When ADSR.cpp is edited to not restart at 0 after a re-trigger, ADSR looks better but sound is still clicking.

It's by applying this change:

	//bool bRestart = phase==kAdsrAttack;
	bool bRestart = phase==kAdsrAttack && previousPhase==kAdsrIdle;

Before
Capture du 2019-12-24 19-24-27

After
Capture du 2019-12-24 19-24-33

To check whether the retrigger is resetting oscillator's phase (which it shouldn't)

@jpcima
Copy link
Member Author

jpcima commented Dec 24, 2019

It should be fixed, testing needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant