Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Soundex for Arabic text #62

Open
linuxscout opened this issue Jul 16, 2022 · 3 comments
Open

Soundex for Arabic text #62

linuxscout opened this issue Jul 16, 2022 · 3 comments

Comments

@linuxscout
Copy link
Owner

No description provided.

@OdaiGH
Copy link
Contributor

OdaiGH commented Oct 31, 2023

Hello friend,

check my PR #73

@linuxscout
Copy link
Owner Author

أهلا أخي عديّ،
شكرا جزيلا على هذه المساهمة القيّمة،

هل أطلب منك بعض التعديلات،

  • حذف قسم import future لأن المكتبة حاليا تدفع فقط py3
  • إضافة unittest لدوال soundex
  • تحويل السلاسل الجًملية camels إلى سلاسل ذات سطر سفلي (arSoundexTrimRep تصبح soundex_trim_remp)
  • لا داعي لإضافة ar في بداية المعرفات أو اسماء الدوال

مع تحياتي الطيبة

@OdaiGH
Copy link
Contributor

OdaiGH commented Nov 1, 2023

@linuxscout تم يا غالي

Check now, let me know if anything needs to be fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@linuxscout @OdaiGH