Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Log IP address that was sent to duckdns.org #72

Closed
1 task done
petermicuch opened this issue Mar 26, 2024 · 4 comments
Closed
1 task done

[FEAT] Log IP address that was sent to duckdns.org #72

petermicuch opened this issue Mar 26, 2024 · 4 comments
Assignees

Comments

@petermicuch
Copy link

Is this a new feature request?

  • I have searched the existing issues

Wanted change

I would like to be able to see IP address that was sent to duckdns.org in the log of the container. It would be fine to only add this extended logging upon setting of ENV variable (i.e. EXTENDED_LOGING_ENABLED) for extending logging.

Reason for change

This would allow me to detect when the change of IP has happened and could relate it to small hiccups that are happening to instance of a service that I run in my network.

Proposed code change

change in https://github.com/linuxserver/docker-duckdns/blob/master/root/app/duck.sh

echo "Your IP was updated at $(date). IPV4 is ${IPV4} and IPV6 is ${IPV6}"

I would provide PR to only log IPV4 or IPV6 or both based on configured option of UPDATE_IP variable.

Copy link

Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.

@aptalca
Copy link
Member

aptalca commented Mar 26, 2024

We'll take that into consideration but in the meantime, duckdns website shows the last changed date for each subdomain when logged in.

@aptalca aptalca self-assigned this Mar 26, 2024
@petermicuch
Copy link
Author

@aptalca - thank you for giving me hint for immediate chance to track my issue.

I still think that having this also locally visible in my cluster would be nice. I could also run a job myself, but repeating same steps does not make much sense to me.
Even better would be if such log is printed when change is detected (this does not need to survive restarts of the container of course). Log stating that the IP was updated every 5 minutes is not bringing much of new information. Especially when there is log upon failure of update in the same interval. So having log written only when actual change has happened or when an error happened would be more beneficial. At least in my opinion.

@homerr homerr mentioned this issue Mar 29, 2024
1 task
@homerr
Copy link
Member

homerr commented Apr 6, 2024

We've made some enhancements to the container that take care of this one.

Enjoy!

@homerr homerr closed this as completed Apr 6, 2024
@LinuxServer-CI LinuxServer-CI moved this from Issues to Done in Issue & PR Tracker Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants