Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Un-hardcode the environmental parameters #211

Closed
1 task done
fsackur opened this issue Aug 14, 2023 · 7 comments
Closed
1 task done

[FEAT] Un-hardcode the environmental parameters #211

fsackur opened this issue Aug 14, 2023 · 7 comments

Comments

@fsackur
Copy link

fsackur commented Aug 14, 2023

Is this a new feature request?

  • I have searched the existing issues

Wanted change

Env vars are ignored, and incorrect values are shown in the logs.

e.g. in docker-compose:

      - JELLYFIN_DATA_DIR=/var/lib/jellyfin/data
      - JELLYFIN_CACHE_DIR=/var/lib/jellyfin/cache

log shows:

Environment Variables: ["[JELLYFIN_CACHE_DIR, /config/cache]", "[JELLYFIN_DATA_DIR, /data]"

I see #204. @aptalca shut down that discussion. If I phrase this as a feature request, could that person please not hammer me?

Reason for change

  • I don't want cache or logs on /
    • Jellyfin rages on first run if the cache folder already exists, making it a chore to create symlinks on the host
    • ...and I run docker so I don't have to live in a maze of twisty passages
  • I don't want the next poor user to lose time trying to figure out this bug
  • It's a sin to lose basic functionality from the official image

Proposed code change

root/etc/s6-overlay/s6-rc.d/svc-jellyfin/run

JELLYFIN_DATA_DIR=${JELLYFIN_DATA_DIR:-/config/data} \
JELLYFIN_CONFIG_DIR=${JELLYFIN_CONFIG_DIR:-/config} \
JELLYFIN_LOG_DIR=${JELLYFIN_LOG_DIR:-/config/log} \
JELLYFIN_CACHE_DIR=${JELLYFIN_CACHE_DIR:-/config/cache}  \
JELLYFIN_WEB_DIR=${JELLYFIN_WEB_DIR:-/usr/share/jellyfin/web} 
@fsackur fsackur added the enhancement New feature or request label Aug 14, 2023
@github-actions
Copy link

Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.

@fsackur
Copy link
Author

fsackur commented Aug 14, 2023

Please confirm a PR is acceptable with the code fix and an update to README.md. If not, then go ahead and close.

@LinuxServer-CI
Copy link
Collaborator

This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@nikp123
Copy link

nikp123 commented Oct 27, 2023

Is there ANY sane reason to hard-code these??? I am having trouble migrating from jellyfin/jellyfin because of this.

@aptalca
Copy link
Member

aptalca commented Oct 27, 2023

Yes, we have reasons.

We don't officially support migrations between images of different devs. With that said, migration is fairly straightforward as long as you set up the new container with a different config folder first, so you can see the folder structure the new image expects. Then it's a matter of matching your existing data to the new format and restarting/recreating the container

@LinuxServer-CI
Copy link
Collaborator

This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@LinuxServer-CI LinuxServer-CI closed this as not planned Won't fix, can't repro, duplicate, stale Jan 28, 2024
@LinuxServer-CI LinuxServer-CI moved this from Issues to Done in Issue & PR Tracker Jan 28, 2024
Copy link

This issue is locked due to inactivity

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

No branches or pull requests

4 participants