-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Summarise created and updated datetimes #109
Merged
kodiakhq
merged 7 commits into
master
from
feat/summarise-created-and-updated-datetimes
Oct 11, 2021
Merged
feat: Summarise created and updated datetimes #109
kodiakhq
merged 7 commits into
master
from
feat/summarise-created-and-updated-datetimes
Oct 11, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
const example = JSON.parse(await fs.readFile(examplePath)); | ||
delete example['linz:created']; | ||
const collection = JSON.parse(await fs.readFile(examplePath)); | ||
delete collection['summaries']['created']; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests may need to be updated after your earlier PR updating the language in other tests
l0b0
force-pushed
the
feat/summarise-created-and-updated-datetimes
branch
from
October 11, 2021 03:00
fa007c5
to
81ebbd9
Compare
l0b0
force-pushed
the
feat/summarise-created-and-updated-datetimes
branch
from
October 11, 2021 03:01
81ebbd9
to
beffbbb
Compare
billgeo
reviewed
Oct 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
MitchellPaff
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #73.