Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Summarise created and updated datetimes #109

Merged
merged 7 commits into from
Oct 11, 2021

Conversation

l0b0
Copy link
Contributor

@l0b0 l0b0 commented Oct 11, 2021

Closes #73.

const example = JSON.parse(await fs.readFile(examplePath));
delete example['linz:created'];
const collection = JSON.parse(await fs.readFile(examplePath));
delete collection['summaries']['created'];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests may need to be updated after your earlier PR updating the language in other tests

@l0b0 l0b0 force-pushed the feat/summarise-created-and-updated-datetimes branch from fa007c5 to 81ebbd9 Compare October 11, 2021 03:00
@l0b0 l0b0 requested a review from MitchellPaff October 11, 2021 03:00
@l0b0 l0b0 force-pushed the feat/summarise-created-and-updated-datetimes branch from 81ebbd9 to beffbbb Compare October 11, 2021 03:01
Copy link
Contributor

@billgeo billgeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@l0b0 l0b0 added the automerge kodiak automerge label label Oct 11, 2021
@billgeo billgeo self-requested a review October 11, 2021 03:38
@kodiakhq kodiakhq bot merged commit d6ec59c into master Oct 11, 2021
@kodiakhq kodiakhq bot deleted the feat/summarise-created-and-updated-datetimes branch October 11, 2021 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge kodiak automerge label
Development

Successfully merging this pull request may close these issues.

Change collection level 'updated' / 'created' datetimes to a summary of asset datetimes
3 participants