feat: Fix strict ajv warnings #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
MitchellPaff
previously approved these changes
Nov 17, 2021
l0b0
force-pushed
the
feat/fix-strict-ajv-warnings
branch
from
cbb5a3f to
ea3ae04
Compare
amfage
reviewed
Nov 22, 2021
l0b0
force-pushed
the
feat/fix-strict-ajv-warnings
branch
2 times, most recently
from
244ab5d to
c4995c8
Compare
l0b0
force-pushed
the
feat/fix-strict-ajv-warnings
branch
from
16d5ef2 to
71cdb55
Compare
l0b0
requested review from
amfage,
MitchellPaff and
billgeo
and removed request for
blacha,
billgeo,
amfage,
MDavidson17 and
MitchellPaff
l0b0
force-pushed
the
feat/fix-strict-ajv-warnings
branch
from
ab8d690 to
c2d30a0
Compare
MitchellPaff
previously approved these changes
Nov 29, 2021
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
See <https://ajv.js.org/strict-mode.html>. These are the last warnings in our schemas - see `npx ospec 2> >(grep --fixed-strings --invert-match --regex='stac-extensions.github.io' --regex=schemas.stacspec.org >&2)`.
l0b0
force-pushed
the
feat/fix-strict-ajv-warnings
branch
from
5a29302 to
c9045c1
Compare
amfage
approved these changes
Dec 5, 2021
MitchellPaff
approved these changes
Dec 5, 2021
blacha
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://ajv.js.org/strict-mode.html.
These are the last warnings in our schemas - see
npx ospec 2> >(grep --fixed-strings --invert-match --regex='stac-extensions.github.io' --regex=schemas.stacspec.org >&2)(this command basically removes the warnings for stac-extensions.github.io and schemas.stacspec.org from standard error, showing only the LINZ-related ajv warnings).