Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add asset language property #173

Merged
merged 3 commits into from
Nov 22, 2021
Merged

feat: Add asset language property #173

merged 3 commits into from
Nov 22, 2021

Conversation

l0b0
Copy link
Contributor

@l0b0 l0b0 commented Nov 18, 2021 •
edited
Loading

Closes #161.

MitchellPaff
MitchellPaff previously approved these changes Nov 18, 2021
View reviewed changes
@l0b0 l0b0 requested a review from palmerj November 18, 2021 21:35
@l0b0 l0b0 added the automerge kodiak automerge label label Nov 21, 2021
@kodiakhq kodiakhq bot removed the automerge kodiak automerge label label Nov 21, 2021
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Nov 21, 2021

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

@l0b0 l0b0 force-pushed the feat/add-asset-language-property branch from c85dfba to 5e0200a Compare November 21, 2021 20:49
@l0b0 l0b0 added the automerge kodiak automerge label label Nov 21, 2021
@l0b0 l0b0 requested a review from MitchellPaff November 21, 2021 20:50
billgeo
billgeo suggested changes Nov 22, 2021
View reviewed changes
Copy link
Contributor

@billgeo billgeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except needs some README goodness?

l0b0 added 3 commits November 22, 2021 15:05
@l0b0
feat: Add asset language property
4a753df
@l0b0
feat: Enforce that linz:language is a string
259f359 
We don't need to test on the item as well because we've de-duped that
part of the schema.
@l0b0
feat: Enforce that linz:language is an RFC 5646 language tag
8fad15a 
Got the language tags using `jq '.[].lang' <(curl --location
https://datahub.io/core/language-codes/r/ietf-language-tags.json)`.
@l0b0 l0b0 force-pushed the feat/add-asset-language-property branch from 5e0200a to 8fad15a Compare November 22, 2021 02:05
@l0b0 l0b0 requested a review from billgeo November 22, 2021 02:06
@l0b0 l0b0 removed the automerge kodiak automerge label label Nov 22, 2021
@l0b0 l0b0 requested review from amfage and paulfouquet November 22, 2021 19:18
@l0b0 l0b0 added the automerge kodiak automerge label label Nov 22, 2021
@kodiakhq kodiakhq bot merged commit 66bd0d5 into master Nov 22, 2021
@kodiakhq kodiakhq bot deleted the feat/add-asset-language-property branch November 22, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amfage amfage amfage approved these changes

@billgeo billgeo billgeo approved these changes

@blacha blacha Awaiting requested review from blacha

@dwsilk dwsilk Awaiting requested review from dwsilk

@palmerj palmerj Awaiting requested review from palmerj

@MitchellPaff MitchellPaff Awaiting requested review from MitchellPaff

@paulfouquet paulfouquet Awaiting requested review from paulfouquet

Assignees
No one assigned
Labels
automerge kodiak automerge label
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: add 'language' fields for assets
4 participants
@l0b0 @billgeo @amfage @MitchellPaff