feat: add summaries to historical imagery related extensions #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MDavidson17
requested review from
amfage,
dwsilk,
l0b0,
blacha and
paulfouquet
l0b0
reviewed
Nov 22, 2021
blacha
reviewed
Nov 22, 2021
You're right, we have raised an issue on the STAC spec about summarising assets. |
|
l0b0
previously approved these changes
Nov 22, 2021
paulfouquet
previously approved these changes
Nov 23, 2021
extensions/scanning/schema.json
Outdated
| "required": ["minimum", "maximum"], | ||
| "properties": { | ||
| "minimum": { | ||
| "title": "earliest date", |
amfage
reviewed
Nov 23, 2021
amfage
previously approved these changes
Nov 24, 2021
l0b0
previously approved these changes
Nov 24, 2021
paulfouquet
reviewed
Nov 24, 2021
extensions/scanning/schema.json
Outdated
| "pattern": "(\\+00:00|Z)$" | ||
| }, | ||
| "maximum": { | ||
| "title": "most recent date", |
paulfouquet
previously approved these changes
Nov 24, 2021
dwsilk
dismissed stale reviews from paulfouquet, l0b0, and amfage
via
6d03490
dwsilk
force-pushed
the
feat/summaries
branch
from
c62d9e1 to
6d03490
Compare
dwsilk
force-pushed
the
feat/summaries
branch
from
6d03490 to
ccc9a81
Compare
amfage
approved these changes
Nov 24, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extensions updated to include summary requirements:
nb: eo:bands cannot be added to the historical imagery schema as it would be an asset summary (please correct me if I'm wrong here).