Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Include real projection extension fields #87

Merged
merged 4 commits into from
Oct 7, 2021

Conversation

l0b0
Copy link
Contributor

@l0b0 l0b0 commented Oct 6, 2021

Closes #85

@l0b0 l0b0 added the automerge kodiak automerge label label Oct 6, 2021
@l0b0 l0b0 requested a review from MitchellPaff October 6, 2021 23:13
@l0b0 l0b0 force-pushed the fix/include-real-projection-extension-fields branch from 2a9d692 to 0453144 Compare October 6, 2021 23:23
@kodiakhq kodiakhq bot removed the automerge kodiak automerge label label Oct 6, 2021
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Oct 6, 2021

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

l0b0 added 4 commits October 7, 2021 13:21
- The fields apply to assets, not the top level.
- `proj:espg` should have been `proj:epsg`.
- `proj:epsg` is not required.
- The extension URL needs to be listed.
They should be as similar as possible to easily be able to work out the
relevant difference, and to make sure it's easy to detect invalid tests.
@l0b0 l0b0 force-pushed the fix/include-real-projection-extension-fields branch from 0453144 to 4fe1af8 Compare October 7, 2021 00:24
@l0b0 l0b0 added the automerge kodiak automerge label label Oct 7, 2021
@kodiakhq kodiakhq bot merged commit 95322f8 into master Oct 7, 2021
@kodiakhq kodiakhq bot deleted the fix/include-real-projection-extension-fields branch October 7, 2021 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge kodiak automerge label
Development

Successfully merging this pull request may close these issues.

Bug: no_projection_espg_code.json is failing validation for the wrong reason
2 participants