Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: log gdal stderr instead of raising an exception TDE-557 #203

Merged

Conversation

paulfouquet
Copy link
Collaborator

@paulfouquet paulfouquet commented Nov 6, 2022

Description

stderr from gdal should not be interpreted as an error. When gdal is on error, it returns an exit code <> 0. This behaviour is already captured by subprocess.run (with check=True) raising a subprocess.CalledProcessError in a case of "a non-zero exit status". Any stderr should be Warnings or other messages <> error.

Change

Log a warning instead of raising an exception when gdal stderr is not empty

@paulfouquet paulfouquet requested a review from a team as a code owner November 6, 2022 22:41
@kodiakhq kodiakhq bot merged commit 4032145 into master Nov 7, 2022
@kodiakhq kodiakhq bot deleted the fix/log-gdal-stderr-instead-raising-exception-tde-557 branch November 7, 2022 00:23
@github-actions github-actions bot mentioned this pull request Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants