feat: fs.exists() checks if path exists TDE-710 #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blacha
reviewed
Apr 12, 2023
scripts/files/fs_s3.py
Outdated
|
|
||
| bucket_name = bucket_name_from_path(s3_path) | ||
| bucket = s3.Bucket(bucket_name) | ||
| objects = bucket.objects.filter(Prefix=key) |
There was a problem hiding this comment.
generally you would do a head to see if a key exists, this is checking for anything that starts with this path
so exists s3://foo/bar.tiff would succeed if you did exists s3://foo/bar.tiff.bak
There was a problem hiding this comment.
Oh, that's right.
I'm going to fix that
There was a problem hiding this comment.
@blacha this is now checking if the path is a "directory" aka ends with / to determine wether it does a head or a list.
amfage
previously approved these changes
Apr 12, 2023
MDavidson17
approved these changes
Apr 13, 2023
amfage
approved these changes
Apr 17, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fs.exists()checks if as3or local path points to an existing file/directory/object