Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: tde-421 remove destination arguments #61

Merged
merged 10 commits into from
Jul 24, 2022

Conversation

MDavidson17
Copy link
Contributor

@MDavidson17 MDavidson17 commented Jul 19, 2022

the destination arguement has been removed therefore the output of standardardisation will only be written to the tmp directory in the docker container. combined with linz/topo-workflows#7 the tmp folder will then be written to the artifacts bucket.

note: this branch includes COG work, it needs to be rebased once #60 is merged

@MDavidson17 MDavidson17 marked this pull request as ready for review July 20, 2022 00:55
@MDavidson17 MDavidson17 requested a review from a team as a code owner July 20, 2022 00:55
@MDavidson17 MDavidson17 force-pushed the feat/tde-421-remove-destination-arg branch from 04d5eb7 to 7ee50da Compare July 20, 2022 01:43
@MDavidson17 MDavidson17 force-pushed the feat/tde-421-remove-destination-arg branch from 2b3b1c8 to 7c88909 Compare July 20, 2022 01:48
amfage
amfage previously approved these changes Jul 20, 2022
@MDavidson17 MDavidson17 force-pushed the feat/tde-421-remove-destination-arg branch from 7c88909 to d705877 Compare July 22, 2022 02:46
@kodiakhq
Copy link

kodiakhq bot commented Jul 24, 2022

This PR currently has a merge conflict. Please resolve this and then re-add the automerge 🚀 label.

@kodiakhq kodiakhq bot merged commit ba69fea into master Jul 24, 2022
@kodiakhq kodiakhq bot deleted the feat/tde-421-remove-destination-arg branch July 24, 2022 23:37
@github-actions github-actions bot mentioned this pull request Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants