Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incompatibility with node-sass #891

Closed
Donov4n opened this issue Nov 24, 2021 · 2 comments · Fixed by #892
Closed

Incompatibility with node-sass #891

Donov4n opened this issue Nov 24, 2021 · 2 comments · Fixed by #892

Comments

@Donov4n
Copy link

Donov4n commented Nov 24, 2021

Hello everyone :)

The change introduced in #838 prevent all users using node-sass on legacy projects to update to the latest version of flag-icon-css.
Maybe a solution like the bootstrap one (or a 1.33 multiplication instead of the 4 / 3 division if the tiny loss of precision is acceptable) would have been a better move for everyone ?

See also:
@lipis
Copy link
Owner

lipis commented Nov 24, 2021

Do you mine changing it to 1.33333?

@lipis lipis mentioned this issue Nov 25, 2021
Merged
@Donov4n
Copy link
Author

Donov4n commented Nov 25, 2021

Thank you @lipis !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't use math in sass lipis/flag-icons
2 participants
@lipis @Donov4n