Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve weird dependency #2

Open
1 task
zanerock opened this issue Oct 3, 2023 · 1 comment
Open
1 task

Resolve weird dependency #2

zanerock opened this issue Oct 3, 2023 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@zanerock
Copy link
Member

zanerock commented Oct 3, 2023

Overview

In order to get the test running, we had to add @babel/plugin-proposal-class-properties and @babel/plugin-proposal-optional-chaining as developer dependencies. Otherwise we would get an error from babel (7.23.0) that it could not load these dependencies. As far as we can tell, the dependency load is coming from within babel ad not based on any config of ours.

"Parsing error: Cannot resolve module '@babel/plugin-proposal-optional-chaining' from paths ['/Users/zane/.liq/playground/liquid-labs/catalyst-resource-eslint/dist/babel'] from /Users/zane/.liq/playground/liquid-labs/catalyst-resource-eslint/node_modules/@babel/core/lib/config/files/plugins.js\n" +
          '- Did you mean "@babel/plugin-transform-optional-chaining"?\n' +
          '\n' +
          'Make sure that all the Babel plugins and presets you are using\n' +
          'are defined as dependencies or devDependencies in your package.json\n' +
          "file. It's possible that the missing plugin is loaded by a preset\n" +
          'you are using that forgot to add the plugin to its dependencies: you\n' +
          'can workaround this problem by explicitly adding the missing package\n' +
          'to your top-level package.json.',

Deliverables

  • track down the source of this and, if possible, fix so that we don't have to have the two random dev dependencies in our package
@zanerock zanerock added the enhancement New feature or request label Oct 3, 2023
@zanerock zanerock added this to the 1.0.0-beta milestone Oct 3, 2023
@zanerock
Copy link
Member Author

zanerock commented Oct 3, 2023

I'm not labeling this a bug since it isn't our code (I don't think).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant