Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent mount point collision on validation #258

Open
yitsushi opened this issue Nov 12, 2021 · 6 comments
Open

Prevent mount point collision on validation #258

yitsushi opened this issue Nov 12, 2021 · 6 comments
Labels
good first issue Good for newcomers help wanted Requires help from contributors to get done kind/feature New feature or request priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@yitsushi
Copy link
Contributor

Describe the solution you'd like:
It is possible to set multiple volumes to be mounted to the same path. We can assume the end-user knows what they are doing, but should be a very straightforward validation.

Why do you want this feature:
To prevent unnecessary failures because of user error.

Anything else you would like to add:
Validate 2 things:

  • Root volume mount point is /
  • Do not allow multiple volumes to be mounted on the same path

Reference: #241 (comment)

@yitsushi yitsushi added the kind/feature New feature or request label Nov 12, 2021
@richardcase richardcase added good first issue Good for newcomers help wanted Requires help from contributors to get done priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Nov 17, 2021
@github-actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 17, 2022
@yitsushi
Copy link
Contributor Author

This is still needed.

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 18, 2022
@Callisto13
Copy link
Member

For now we are saying that any issues are user error and we dont care rn

@github-actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 19, 2023
@yitsushi
Copy link
Contributor Author

Didn't we add check for that somewhere? Maybe @jmickey you know more.

Copy link
Contributor

This issue was closed because it has been stalled for 365 days with no activity.

@github-actions github-actions bot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label May 19, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Closed in Liquid Metal Roadmap - Public May 19, 2024
@richardcase richardcase reopened this Jul 10, 2024
@richardcase richardcase removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Requires help from contributors to get done kind/feature New feature or request priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
No open projects
Status: Closed
Development

No branches or pull requests

3 participants