Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Known Issue 1 - Loss of yield for votes that cannot meet threshold #21

Open
GalloDaSballo opened this issue Oct 11, 2024 · 0 comments
Open

Comments

@GalloDaSballo
Copy link
Collaborator

GalloDaSballo commented Oct 11, 2024

See the changes to

    // forge test --match-test test_claimForInitiative -vv
    function test_claimForInitiative() public {

V2-gov/test/Governance.t.sol

Lines 1153 to 1160 in e4ccbc0

assertEq(governance.claimForInitiative(baseInitiative1), 10000e18);
assertEq(governance.claimForInitiative(baseInitiative1), 0);
assertEq(lusd.balanceOf(baseInitiative1), 15000e18);
assertEq(governance.claimForInitiative(baseInitiative2), 0);
assertEq(governance.claimForInitiative(baseInitiative2), 0);

        /// @audit this fails, because by counting 100% of votes, the ones that don't make it steal the yield
        /// This is MED at most, in this test a 50 BPS loss
        /// Due to this, we'll acknowledge it for now
        assertEq(governance.claimForInitiative(baseInitiative1), 9950e18);
        assertEq(governance.claimForInitiative(baseInitiative1), 0);


        assertEq(lusd.balanceOf(baseInitiative1), 14950e18);
@GalloDaSballo GalloDaSballo changed the title Loss of yield for votes that cannot meet threshold Known Issue 1 - Loss of yield for votes that cannot meet threshold Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant