Make headless mode work more reliably #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lirantal
reviewed
Aug 8, 2020
lirantal
approved these changes
Aug 8, 2020
|
🎉 This PR is included in version 1.4.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Running this in the environment of Github Actions, I need the headless mode for puppeteer. Both locally and on Github Actions, setting
headless: trueresults in the first step of the login form never completing. When headless is false, it's fine.This PR adds some headers to the page, which helps Google to render the correct page contents on the first step of the signup flow. Apparently different content is rendered for headless browsers if the correct headers are not present.
Types of changes
Related Issue
checkly/puppeteer-examples#36
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Checklist: