Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export baseLoginConnect function #59

Merged
merged 1 commit into from
Oct 12, 2020

Conversation

fkropfhamer
Copy link
Contributor

@fkropfhamer fkropfhamer commented Oct 12, 2020

Export baseLoginConnect function

Export the baseLoginConnect function to allow providing custom typeUsername, typePassword and authorizeApp for custom logins.

Description

Added baseLoginConnect function to exports

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Related Issue

Fixed #58

https://github.com/lirantal/cypress-social-logins/issues/58

Motivation and Context

How Has This Been Tested?

Test in example application, which uses custom OAuth login

Screenshots (if appropriate):

Checklist:

  • I have updated the documentation (if required).
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I added a picture of a cute animal cause it's fun

export baseLoginConnect function
@lirantal
Copy link
Owner

This is it?

@fkropfhamer
Copy link
Contributor Author

I want to add support for facebook login later, but for the moment this would be enough.

@lirantal
Copy link
Owner

Coolness! Let me merge and get a new version out

@lirantal lirantal added enhancement New feature or request hacktoberfest labels Oct 12, 2020
@lirantal lirantal merged commit c98a9ad into lirantal:master Oct 12, 2020
@fkropfhamer
Copy link
Contributor Author

Thanks a lot!

@lirantal
Copy link
Owner

🎉 This PR is included in version 1.5.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create an Export function for Custom Logins
2 participants