Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependencies of Puppeteer not fully packaged #1

Closed
lirc572 opened this issue Jan 11, 2021 · 1 comment
Closed

Dependencies of Puppeteer not fully packaged #1

lirc572 opened this issue Jan 11, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@lirc572
Copy link
Owner

lirc572 commented Jan 11, 2021

See microsoft/vscode-vsce#432

vsce package --no-yarn works in my local environment (Windows 10) but fails in GitHub actions (Ubuntu 18.04)
@lirc572 lirc572 added the bug Something isn't working label Jan 11, 2021
@lirc572
Copy link
Owner Author

lirc572 commented Jan 12, 2021

The problem is that Puppeteer only installs chromium for the current OS. It has been fixed by building on all target OSes.

@lirc572 lirc572 closed this as completed Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lirc572