Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept outside logger, do not panic #105

Open
vbmithr opened this issue Jun 2, 2024 · 1 comment
Open

Accept outside logger, do not panic #105

vbmithr opened this issue Jun 2, 2024 · 1 comment

Comments

@vbmithr
Copy link

vbmithr commented Jun 2, 2024

Hi, I've started using this project. I'm thinking about rewriting the parts that instantiate zap loggers and instead get them from outside, also, as a library, it should return errors instead of panicking.

What do you guys think about this?
Best,
Vincent

@ethanf
Copy link
Collaborator

ethanf commented Jun 5, 2024

Generally agree with this. For error handling, we want to stick as closely to the behavior of the other languages (Java/C++) to reduce surprises and make it easy to port functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants