Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groupie resets child recycler state when parent recyclerview scroll #264

Closed
mahmoudashrafmohamed opened this issue Jun 27, 2019 · 5 comments

Comments

@mahmoudashrafmohamed
Copy link

when i use nested recyclerview and scroll ,
the child recycler ( horizontal recyclerview inside vertical recyclerview ) reset to first element

@ValCanBuild
Copy link
Collaborator

Hi @mahmoudashrafmohamed . Can you please provide a bit more detail and examples. Steps to reproduce would also help.

@mahmoudashrafmohamed
Copy link
Author

hi @ValCanBuild . For example if i use CarouselItem ( recycler with a horizontal layout manager in a vertically scrolling RecyclerView ) as an items in groupAdapter , vertically scrolling of recycler not restore the state of CarouselItem ( horizontal recycler will scrolled to position 0 ) .

@khatv911
Copy link

khatv911 commented Aug 18, 2019

you have to make sure to implement diffing in the CarouselItem, otherwise, set items inside the carousel will be the same as notifydatasetchanged.
@ValCanBuild it's not a bug.

@ValCanBuild
Copy link
Collaborator

Thanks for the info, @khatv911 . Happy to close it

@ghost
Copy link

ghost commented Sep 28, 2020

@khatv911
Sorry but can you give more details on how to handle this kind of scenario?
Looks it's likely an issue, maybe not a bug.

Found a PR for more details: #309

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants