Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(no-duplicate-store-ids): fix the error message that shouldn't appear in vscode #57

Merged
merged 3 commits into from
Aug 24, 2024

Conversation

9romise
Copy link
Collaborator

@9romise 9romise commented Jul 26, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What did you change?

Issue Number: Closes #56

Why did you change it?

Cache store id by file path.
Add e2e test.
Add a notice about the VSCode plugin in the doc.

Other information

@9romise
Copy link
Collaborator Author

9romise commented Jul 26, 2024

The failed test is due to execa v9 no longer supports node.js v16.
execa is a devDependence, so it can be solved directly by downgrading.
But since node.js v16 has reached EOL in September 2023, should we also drop support for nodejs16 versions?

@lisilinhart lisilinhart merged commit 0d7f541 into lisilinhart:main Aug 24, 2024
4 of 6 checks passed
Copy link

🎉 This issue has been resolved in version 0.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@9romise 9romise deleted the fix/no-duplicate-store-ids branch September 14, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no-duplicate-store-ids 这个有bug
2 participants