Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Symbol not working #24

Open
BartolomeyKant opened this issue Mar 15, 2022 · 1 comment · Fixed by pragtical/lsp#3 · May be fixed by #131
Open

Rename Symbol not working #24

BartolomeyKant opened this issue Mar 15, 2022 · 1 comment · Fixed by pragtical/lsp#3 · May be fixed by #131

Comments

@BartolomeyKant
Copy link

I am using lsp plugin for c++ coding with clangd server.
Today I tried to rename symbol and its not working.

There is no errors just a message in the logs:

[Tue Mar 15 13:57:58 2022] {
  "id": 2,
  "result": {
    "changes": {
      "file:///home/bartolomey/projects/remote-helper/libs/remote-helper-new-core/remote-helper-new-core/file_copy_processor/file_functions.hpp": [
        {
          "newText": "removeit",
          "range": {
            "start": {
              "line": 58,
              "character": 5
            },
            "end": {
              "line": 58,
              "character": 11
            }
          }
        }
      ]
    }
  },
  "jsonrpc": "2.0"
} at /home/bartolomey/.config/lite-xl/plugins/lsp/init.lua:1426
@jgmdev
Copy link
Member

jgmdev commented Mar 15, 2022

Haven't finished implementing mainly because I have to write a UI to confirm the changes

jgmdev added a commit to jgmdev/lsp that referenced this issue Dec 19, 2023
@jgmdev
Finally implemented textDocument/rename fixes lite-xl/lite-xl-lsp#24
7592d8f
@jgmdev jgmdev mentioned this issue Dec 19, 2023
Merged
@Guldoman Guldoman reopened this Dec 19, 2023
@Guldoman Guldoman linked a pull request Jul 12, 2024 that will close this issue
Symbol Rename #131
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Finally implemented textDocument/rename jgmdev/lsp
Symbol Rename Mandarancio/lite-xl-lsp
3 participants
@jgmdev @Guldoman @BartolomeyKant