Skip to content
This repository has been archived by the owner on Sep 16, 2021. It is now read-only.

Is this project dead? #6

Open
APshenkin opened this issue Jul 16, 2018 · 2 comments
Open

Is this project dead? #6

APshenkin opened this issue Jul 16, 2018 · 2 comments

Comments

@APshenkin
Copy link

Hi!

Found this project from https://insight.litecore.io/.

I see, that you still use litecoin-0.13.2. Do you plan to update to 0.16 ?

@LitecoinTim
Copy link

Good you found the project - it certainly isn't dead! We'll be working on updating the public nodes - can't give you an ETA yet though.

@APshenkin
Copy link
Author

APshenkin commented Jul 18, 2018

@LitecoinTim
Thank you for response!

Maybe I can help you with node patching.
I've already applyed patches for 0.15.1 and 0.16.0 version. You can check the code here:
https://github.com/APshenkin/litecoin/tree/0.15.1-litecore
https://github.com/APshenkin/litecoin/tree/0.16.0-litecore

Here is comparation for 0.15.1 version (usual node and litecore node)
litecoin-project/litecoin@v0.15.1...APshenkin:0.15.1-litecore

and for 0.16.0 version
litecoin-project/litecoin@v0.16.0...APshenkin:0.16.0-litecore

Patches was dumped from satoshilabs (because only them applyed patches to 0.15.1 version for bitcoin https://github.com/satoshilabs/bitcoin/tree/0.15.0)

There are two things that I did not complete:

  1. Testing. Looks like it's working after building, but we need more complex tests
  2. For 0.16.0 version I returned CBitcoinAddressVisitor to base58.cpp because it used in patches (https://github.com/APshenkin/litecoin/blob/0.16.0-litecore/src/base58.cpp#L338). Maybe there is an option to overwrite patches to not do this. Also in would be great to add bech32 format address view support.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants