Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MinterAccessControl to use Enumerable AddressSet #5

Closed
Hadrienlc opened this issue Nov 19, 2021 · 0 comments · Fixed by #6
Closed

Update MinterAccessControl to use Enumerable AddressSet #5

Hadrienlc opened this issue Nov 19, 2021 · 0 comments · Fixed by #6

Comments

@Hadrienlc
Copy link

The current implementation with a mapping(address => bool) can't be used to enumerate the members of the minter roles.
EnumerableSetUpgradeable.AddressSet will be more flexible and can be reused to implement #3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement feedback on Mint Access Control liteflow-labs/rarible-protocol-contracts
2 participants
@NicolasMahe @Hadrienlc