Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass size definition from page #175

Open
NicolasMahe opened this issue Feb 10, 2023 · 0 comments
Open

Pass size definition from page #175

NicolasMahe opened this issue Feb 10, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@NicolasMahe
Copy link
Member

Related to comment #172 (comment)

As the pages are responsive, many sizes rules are not the same from one page to the other.
Currently, we define the sizes prop in the components following the responsive rules of one page.
This definition should be moved to the page to be able to set the right sizes for every page.

For example, the TokenCard component define the sizes used by TokenMedia using the responsive rules of the explore page.
@NicolasMahe NicolasMahe added the enhancement New feature or request label Feb 10, 2023
@NicolasMahe NicolasMahe mentioned this issue Feb 10, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NicolasMahe